From 2e21aa73c0229eae394b87e72697d6460ac8d5ce Mon Sep 17 00:00:00 2001 From: MrPabloUK <47826763+MrPabloUK@users.noreply.github.com> Date: Sun, 8 Nov 2026 22:06:53 +0000 Subject: [PATCH] Fix hub daily energy by publishing 0 W on the unused charge/discharge sign (#336) - Hub `battery_charging_power` / `battery_discharging_power` left the unused sign as NAN, while the shunt already publishes 0 W. - ESPHome `total_daily_energy` (`method: right`) skips NAN without advancing `last_update_`, so the next finite watt is multiplied by the whole gap (for example a charge spike after a long discharge). - Publish 0 W on the unused sign (and when power is NAN / no BMS is combined) so both daily meters keep integrating. --- packages/yambms/yambms_core.yaml | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/packages/yambms/yambms_core.yaml b/packages/yambms/yambms_core.yaml index 36739ea..0464f4f 100644 --- a/packages/yambms/yambms_core.yaml +++ b/packages/yambms/yambms_core.yaml @@ -1,4 +1,4 @@ -# Updated : 2026.11.06 +# Updated : 2026.11.08 # Version : 1.8.1 # GitHub : https://github.com/Sleeper85/esphome-yambms @@ -545,8 +545,8 @@ interval: float total_voltage = NAN; float current = NAN; float power = NAN; - float battery_charging_power = NAN; - float battery_discharging_power = NAN; + float battery_charging_power = 0; + float battery_discharging_power = 0; float soc = NAN; float soh = NAN; float charging_cycles = NAN; @@ -590,13 +590,18 @@ interval: else power = round(id(yambms${yambms_id}_var_bms_total_power)); - // battery_charging_power - if (power > 0) + // battery_charging_power + if (!std::isnan(power) && power > 0) + { battery_charging_power = power; - + battery_discharging_power = 0; + } // battery_discharging_power - else + else if (!std::isnan(power)) + { + battery_charging_power = 0; battery_discharging_power = power * -1; // Must be positive energy + } // MEAN Battery SOC (Shunt/BMS) if (id(yambms${yambms_id}_var_shunt_use) == true)