From 5c171aea14d4727df91899178fa0d8b48ef73000 Mon Sep 17 00:00:00 2001 From: Sleeper85 Date: Thu, 5 Nov 2026 22:18:10 +0100 Subject: [PATCH] Docs: Explain the 0 A limit in the combiner Document why the combiner accepts 0 A as a valid charge and discharge limit. --- documents/README/dev/Design_decisions.md | 8 +++++--- packages/bms/bms_combine.yaml | 2 +- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/documents/README/dev/Design_decisions.md b/documents/README/dev/Design_decisions.md index 5195c1b..679aec8 100644 --- a/documents/README/dev/Design_decisions.md +++ b/documents/README/dev/Design_decisions.md @@ -42,9 +42,11 @@ The condition in `bms_combine.yaml` checks every sensor the combiner will read. purpose: a single missing or `NaN` value entering the totals corrupts the aggregate that drives the inverter. Do not shorten it to a few representative checks. -Note that the checks are not uniform. Most use `has_state()`, but `total_voltage`, -`battery_capacity`, `max_charge_current` and `max_discharge_current` use `> 0` — a BMS reporting -zero for those is treated as not ready rather than as a valid reading. +Note that the checks are not uniform. Most use `has_state()`, but `total_voltage` and +`battery_capacity` use `> 0` — a BMS reporting zero for those is treated as not ready rather than +as a valid reading. `max_charge_current` and `max_discharge_current` use `>= 0`: `0 A` is a valid +limit that a BMS can announce, and it must not take that BMS out of the combination. A `NaN` still +fails the comparison, so a limit that was never received keeps the BMS uncombined. ### Combined by contribution, combined continuously, uncombined diff --git a/packages/bms/bms_combine.yaml b/packages/bms/bms_combine.yaml index cff2b9a..d6762ad 100644 --- a/packages/bms/bms_combine.yaml +++ b/packages/bms/bms_combine.yaml @@ -1,4 +1,4 @@ -# Updated : 2026.09.02 +# Updated : 2026.11.05 # Version : 1.8.1 # GitHub : https://github.com/Sleeper85/esphome-yambms